I disagree. I think Luke grows, willing to accept his failure and face it. That it was an astral projection takes nothing away from the learning.While I respect where this point of view comes from, I also feel like if you're going to do it then it has to be in a way that eventually uplifts -- there has to be a coming back, you have to give the character a return to grace. It's easy to imagine a Star Trek: Generations like scenario where you hire Shatner or Takei or Koenig or Nichols and recast their character as living alone in some cabin as a bitter old bastard. Heck, Picard may do it. But the arc needs to close with the old hero rediscovering something in themselves and getting their victory lap. Yes, classic characters deserve that. Luke could have had that. But he didn't. Even in those last moments where he goes and confronts Ren, it's just an astral projection and he dies. Where does Luke grow again? He doesn't. He just becomes depressed, cynical, and then dies. I'm sorry but I feel like Luke deserves better than that. I think Star Wars deserves better. I have got faith that Picard isn't like that. I feel like Jean Luc is going to grow and develop more. Luke went nowhere, did nothing, and didn't mean anything. That's no way to treat such an important legacy character.
Also, Luke has a great moment in Rise of Skywalker.