Where I live, almost everyone is fed, clothed and housed. They still want more though. This isn't due to greed; it's due to an innate sense of fairness. You have a nice suit. Why don't i?
Again, modern capitalist society doesn't translate well to a post-scarcity democratic socialist / communist society. In the modern world if you envy your neighbor's suit you can either work to buy one just like it ("keeping up with the Jones's"), you can steal one just like it, or you can steal theirs (greed). In the Trek society you could simply replicate one.
Additionally, what about people who are dicks? Why would those people suddenly just go away?
Hopefully they would be psychologically healthy enough to just not be dicks.
Why assume that only the admirals get to live at the beach? That's rather silly assumption. First, you're assuming everyone would want to live at the beach. You're assuming that "living at the beach" means properly living as close to the sand as possible, rather than within walking distance.
You're also ignoring the ecosystem of replicators here. The matter the replicators use has to come from somewhere. there's a good chance they reclaim all the matter they can for use in replicators. Just like we purify water and treat waste and recycle garbage today. The replicator whips up your breakfast, dishes included, you eat, then put your dishes back in the replicator. When you gotta go to the waste extraction unit, that matter is reclaimed as well for use in the replicator. There's likely an air filtration system as well, pick up all that dead skin / dust floating around.
See what I mean?
It's amusing to me that people think that somehow making the argument of "yeah, but people would still be dicks" somehow utterly destroys the idea that not only can the species improve, but also somehow implies that the species shouldn't even try. "Nope, don't even try to make things better because there will always be dicks". Well, sure, there will always be dicks, just like there will always be trolls. But the presence of trolls isn't reason to destroy the internet. You just ignore them, don't read the comments, and get on with it. So your choices are: Shitty, exploitative society where everyone's basically on their own, so fuck 'em... and a few of the people are dicks; or, a damned-near utopian society where everyone's basic needs are fully met, and a few of the people are dicks. Sorry, but the obvious choice is option two there.
Sure, there will always be dicks, but that's no reason to think a post-scarcity society where everyone's needs are met is a bad idea. I see no reason to be so petty as to punish the species as a whole (not providing for everyone) simply because a few members of the species decide to be dicks just because they can. "Sorry everyone, Timmy's being a dick, so no one gets to eat today. Try again tomorrow." :sad trombone:
To draw from real-world politics for a second... ostensibly in US politics both the Democrats and the Republicans want the same thing, to make the country a better place. Trouble is, they fundamentally disagree on how to accomplish that same goal. No reason to assume that suddenly, simply because everyone's belly is full, bed is soft, and feet are dry that everyone will suddenly agree with each other.
I agree that there are places where Roddenberry's vision falters, and does so quite spectacularly, but it's in the "there's no strife between human" aspect that he pushed not in the "things get better" aspect. People will still disagree, that disagreement between the main characters is largely lacking makes it seem unbelievable.
Petty crime, sure. Major crime, no, probably not.
Most petty crimes are things like shoplifting and other theft. A means to satisfy basic needs that aren't being met. You don't need to steal a loaf of bread when you're hungry if you can replicate a steak at home. You don't need to steal a book to read or a movie to watch when you can call them both up on any computer in your home, of which there would be several. You want the Crown Jewels of the British Empire? Replicate them. That's not good enough... you might be overcome with greed enough to try to steal them.
You're begging the question. Modern society requires money to live, so of course no one whose needs aren't otherwise being met will volunteer to serve. However, as several posters have mentioned, if they were actually serving on a fully functional starship (replicators, holodeck, and all), then not only would the volunteer for no money, they'd sell everything they owned just to go. Why? Because their basic needs would be met and the opportunity is simply that compelling to many.
You mean all the people who have all their basic needs met with nothing to do but sit around and be bored till they find something to do with their lives and thus contribute in some way back to the society that gives them everything they could ever want and need and more? Poor bastards.
That's a leap if ever there was one.
Earth in the 24th century is a welfare state on a grand scale.
And? So what? What's wrong with the government providing for the basic needs of its citizens? Who serves whom? Do the citizens exist to provide for the state, or does the state exist to provide for the citizens what they couldn't otherwise provide for themselves? The state builds the roads for us to use because we can't build them ourselves. Collective resources versus individual resources. You can do a lot more when resources are pooled and shared than when they're hoarded.
This simply takes the concept one step further. Rather than letting the citizens struggle, fight, starve, and die to meet their basic needs, everyone is provided for. Much less or no crime. No hunger. No homelessness. No illiteracy. Many if not most diseases cured and medical attention provided for everyone. So what are the people left to do? Be bored or try to do something interesting with their lives.