The only real risk is over-saturation. So far, we’ve sailed around that cliff. That earned us some unique ships like the OV-165, just like
@Rahul said.
I suppose it's only a matter of time. I watched the episode of "The Toys That Made Us" dealing with Star Trek toys (and for anyone who has Netflix, I highly recommend it) and they talk in depth about Playmates action figure line. They mention, while the line was a huge success for some time, one of their big mistakes was introducing one or two figures with a limited production run of only 1,701 copies. This meant a lot of collectors would go without and ultimately gave up on their goal of a complete set, which really hurt sales.
Also Eaglemoss' emphasis on scraping the bottom of the barrell for Starfleet ships and variations on "hero" ships because they sell better reminds me of how Playmates came out with all these variations on the main characters (The TNG crew as Dixon Hill characters, the DS9 crew in "Trials and Tribbleations", Geordi as the alien from "Identity Crisis", etc.) rather than other characters for the same reason.
Furthermore, the Playmates line lasted about five or so years before fizzling out. We're now at about the same point with Eaglemoss. I love most of these ships and I'm happy to continue buying them when I can afford it, but this ride can't last forever.
Actually it's kind of frustrating to me that some ships from major races, including ships that appeared in multiple episodes, as well as a couple from the movies, still haven't gotten announcements, but far more obscure ships have. Surely movie ships like the Lakul and the Merchantman are a bit more memorable than the Lokirrim ship or the Voth research ship. Surely the Jem'Hadar battleship (3 episodes), Groumall (3 episodes, 4 if you count the Klingon freighter in "Sons and Daughters"), Degra's ship (10 episodes), and the Bajoran scout/transport (14 episodes, if you count stock footage) are more important a one-shot like Irina's ship, let alone the Captain Proton ship.
For my part, I'll probably never have a complete set. For one thing, I've never had the funds to order a subscription. Every month or so, I'll build up the funds to get a ship I want at my local store or off of eBay (though not from the US until this tariff debacle blows over) but that's it. $30 CAD is still usually quite a bit for me. Getting one of the specials or the bigger versions is out of the question for me, as they typically go for three or more times as much. Even if I had that much money to burn, I'd rather get three regular-sized ships. I'm not at all interested in any of the Nemesis ships, the JJ Abrams ships, the Discovery ships, or most of TOS-R ships. (Nothing against TOS-R, which I liked, and I'm actually glad they added in all these unseen ships but most of them don't really excite me, although I do have the Antares). Sometimes, it's just because I don't care for the design of a ship, like the Romulan BOP from "Minefield" (which, for some reason looks more advanced than the one from "Balance of Terror") or most of the Wolf 359 or Dominion War-era kitbashes (with a few exceptions like the Kyushu and Centaur)
I don't mean to get all negative. My collection makes me quite happy and I've ended up getting all of the existing models that I was
really gunning for. Not a day goes my when I don't pick one up to look at it. There's still a few I hope get made, and as customers patronizing a business, we should try to keep them honest, but all things considered, I think we've been pretty lucky with this line, and I, for one, try to remember that.