You seem to be approaching this from a different point of view. Consider this...
Do you subscribe to a streaming service like Netflix, Hulu, Amazon, etc? Those services all have a "my list" type of section. Even though I subscribe to the service and I have access to all their movies, I don't have everything they offer in "my list." They aren't my taste. Likewise, there are some features on my Roku and associated apps that I have hidden from view. They aren't my taste and I'd rather them not clutter my screen.
Just because I CAN access an unlimited amount of something doesn't mean I want to.
I do like the idea of downloaded replicator patterns taking up storage space. I know with digital downloads for movies and music it's possible to run out of space. Sometimes a movie will get deleted or moved to a long-term storage area like a disc or separate hard drive that is not as easily accessed. This frees up room for more immediate demands.
No, there were no apparent problems on starships when it comes to replicator storage space, but how much variety did we really see? Maybe we just assume there was an unlimited database. Maybe a starship with over 1,000 people has more replicator storage space than an apartment that only has room for 2 full-time residents.
Now, this doesn't negate your point of view, either. Perhaps replicator patterns cost money the way games or downloaded movies cost. Perhaps people purchase replicator patterns and, until I get around to buying more patterns, the selections in my home replicator are going to be limited. That idea is just as valid except that it implies money exchanged for goods and services.