Nothing to do with cancer. Fires on space craft are catastrophic.Why shouldn't people smoke in the future? Cancer has probably been cured, and they probably would have advanced cigarettes/cigars that aren't harmful to people's health at that point anyway.
On little pods like Apollo 1, yes. On space hotels? No.