Um.. you do realise that characters.. grow and change? The Thor of his first viewing is not the same as the one in Infinity War? That is the purpose of an arc.
Change yes, become completely different people no.
An arc can only have semblance of believability if it in some way reflects the normal real world process of character development in a way real people in the audience can relate to.
Thor is slightly wiser, more rounded and self aware but nothing else we have seen has indicated he has (or should be expected to) become any less fundamentally prideful, arrogant and vengeful. Nor have we seen him develop any great strategic skills.
Those character traits are literally what he represents in Norse mythology, he is a walking embodiment of exactly those flaws. It's his literary purpose in that mythology to show exactly those traits.
They carried over consistently into the comics and consequently the MCU. Not one portrayal of him has ever shown him otherwise. Furthermore he literally stated his intent earlier in the film, making it clear exactly how he viewed killing Thanos as being both personal and a matter of pride after Loki's death. He then acted on that stated intent exactly the way he has done throughout the mythology, the comics and the MCU, by letting hubris overcome common sense.
The outcome was exactly the same as every single one on one encounter between the two we have seen in the past (including those within timelines), Thor tried to best him by brute force and failed to realise in his pride that he was destined to fail because Thanos is more than a match for him.
Where in that is there any inconsistency across the story arc or disconnect with the source material?