Oh boy. It's...complicated.
My dad worked a lot, and was a great provider. We never wanted for anything, and I had some great opportunities thanks to him. Nice house, private school, car on my 16th birthday, etc. I am very grateful to him for that.
But....
Dad was/is a "functioning alcoholic". He was volatile in his temper, and we were always walking on eggshells around him.
He loved my mother very much, and sometimes I think we just came along with the package. Dad was an engineer, and I'm a psychologist. He was raised southern-Baptist on a farm. I grew up Catholic in Los Angeles. I think he is proud of me, but doesn't "get me". Most of my relationship with my Dad consisted of "Hey Mom, tell Dad I said 'hi'."
When my mother died, pretty much the wheels came off completely. I have seen my dad once in the last ten years. He has never met my son, and has repeatedly declined to come out here to California (he lives in Connecticut) to see us. He remarried 7 months after my mom died to a woman I still have not met (and apparently never will). We talk on the phone once every couple of months, and he sends the kids presents for Christmas and birthdays, but that's about it. We are not close by any definition.
When my sister died last year, he did not come out to spend time with her while she was in hospice (he gave them my number to deal with it all). He did not come for her funeral.
I have made my peace with it all, even if it's an uneasy peace at times. It's his problem, his loss. Not mine. I have a great life. A great family. I also have a grandfather (my mom's dad) who has been everything to me. He is the man I look up to, the man I want to make proud of me.
Ultimately, I have tried to be the father he wasn't to my own kids. I've never spanked them ever. I do things with them. I take time off work when they're sick. I suppose every generation tries to do better than the one before them, which makes me wonder what his childhood was like (very grim, I think).