The “moneyless” Federation society is an artifact of Trek TNG and later, and is based on one of Gene Roddenberry's more half-assed ideas. And this horse has not merely been beaten to death; it's a rotting, putrid, bloated corpse of a topic, festering and crawling with maggots.
I disagree, I think it's actually one of the more forward-thinking concepts put forward in Trek, and it's a lot more sensible concept than you'd think- in fact it's pretty much the only logical conclusion to a world in which energy is interchangeable with matter.