That somewhat infamous scene is right after the transporter accident when Kirk get disoriented in the corridor.
And Emperor Tiberius is correct, that's not an erection, it's Steven Collins natural state. The "Decker-unit" is very apparent in several of Collins TV and movies roles.
If that's his natural state then.. well that's not very good. WTF! Why would you encase that in lycra.